rdblue commented on a change in pull request #1373:
URL: https://github.com/apache/iceberg/pull/1373#discussion_r479575823
##########
File path: core/src/main/java/org/apache/iceberg/BaseMetastoreCatalog.java
##########
@@ -64,8 +65,8 @@ public Table createTable(
baseLocation = defaultWarehouseLocation(identifier);
}
- TableMetadata metadata = TableMetadata.newTableMetadata(
- schema, spec, baseLocation, properties == null ? Maps.newHashMap() :
properties);
+ Map<String, String> tableProps = properties != null ? properties :
ImmutableMap.of();
Review comment:
Should we have defaults for `sortOrder` and `spec` as well? It seems
strange that we do this for properties, but not the others.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
