shardulm94 commented on a change in pull request #1356:
URL: https://github.com/apache/iceberg/pull/1356#discussion_r486856378
##########
File path:
arrow/src/main/java/org/apache/iceberg/arrow/vectorized/VectorizedArrowReader.java
##########
@@ -332,6 +334,10 @@ public static VectorizedArrowReader nulls() {
return NullVectorReader.INSTANCE;
}
+ public static VectorizedArrowReader positions() {
+ return PositionVectorReader.INSTANCE;
+ }
Review comment:
I am unsure if returning a singleton instance for
`PostitionVectorReader` is safe, since it contains a member variable `rowStart`
which seems to differ for every row group created. Can there be a possibility
of multiple tasks running on the same executor JVM and referring to different
`PostionVectorReaders` at the same time?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
