chenjunjiedada commented on a change in pull request #1356:
URL: https://github.com/apache/iceberg/pull/1356#discussion_r487528190
##########
File path:
arrow/src/main/java/org/apache/iceberg/arrow/vectorized/VectorizedArrowReader.java
##########
@@ -332,6 +334,10 @@ public static VectorizedArrowReader nulls() {
return NullVectorReader.INSTANCE;
}
+ public static VectorizedArrowReader positions() {
+ return PositionVectorReader.INSTANCE;
+ }
Review comment:
You are right! I forgot the `static` keyword, it is an eager mode of the
singleton. Just remove using singleton in
52f44687a533f0d9b9895c9dc4326b7ef7785654.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
