chenjunjiedada commented on a change in pull request #1356:
URL: https://github.com/apache/iceberg/pull/1356#discussion_r486879702
##########
File path:
arrow/src/main/java/org/apache/iceberg/arrow/vectorized/VectorizedArrowReader.java
##########
@@ -332,6 +334,10 @@ public static VectorizedArrowReader nulls() {
return NullVectorReader.INSTANCE;
}
+ public static VectorizedArrowReader positions() {
+ return PositionVectorReader.INSTANCE;
+ }
Review comment:
Thanks for your comment.
The `INSTANCE` is defined to return a new `PosistionVectorReader`. It
doesn't have a class scope field such as `instance` and the null checking
logic, so it is not a singleton.
IIUC, spark will assign the number of `spark.executor.cores` of tasks per
executor.
##########
File path:
arrow/src/main/java/org/apache/iceberg/arrow/vectorized/VectorizedArrowReader.java
##########
@@ -332,6 +334,10 @@ public static VectorizedArrowReader nulls() {
return NullVectorReader.INSTANCE;
}
+ public static VectorizedArrowReader positions() {
+ return PositionVectorReader.INSTANCE;
+ }
Review comment:
Thanks for your comment.
The `INSTANCE` is defined to return a new `PosistionVectorReader`. It
doesn't have a class scope field such as `instance` and the null checking
logic, so it is not a singleton.
IIUC, spark will assign the number of `spark.executor.cores` of tasks per
executor.
##########
File path:
arrow/src/main/java/org/apache/iceberg/arrow/vectorized/VectorizedArrowReader.java
##########
@@ -332,6 +334,10 @@ public static VectorizedArrowReader nulls() {
return NullVectorReader.INSTANCE;
}
+ public static VectorizedArrowReader positions() {
+ return PositionVectorReader.INSTANCE;
+ }
Review comment:
Thanks for your comment.
The `INSTANCE` is defined to return a new `PosistionVectorReader`. It
doesn't have a class scope field such as `instance` and the null checking
logic, so it is not a singleton.
IIUC, spark will assign the number of `spark.executor.cores` of tasks per
executor.
##########
File path:
arrow/src/main/java/org/apache/iceberg/arrow/vectorized/VectorizedArrowReader.java
##########
@@ -332,6 +334,10 @@ public static VectorizedArrowReader nulls() {
return NullVectorReader.INSTANCE;
}
+ public static VectorizedArrowReader positions() {
+ return PositionVectorReader.INSTANCE;
+ }
Review comment:
Thanks for your comment.
The `INSTANCE` is defined to return a new `PosistionVectorReader`. It
doesn't have a class scope field such as `instance` and the null checking
logic, so it is not a singleton.
IIUC, spark will assign the number of `spark.executor.cores` of tasks per
executor.
##########
File path:
arrow/src/main/java/org/apache/iceberg/arrow/vectorized/VectorizedArrowReader.java
##########
@@ -332,6 +334,10 @@ public static VectorizedArrowReader nulls() {
return NullVectorReader.INSTANCE;
}
+ public static VectorizedArrowReader positions() {
+ return PositionVectorReader.INSTANCE;
+ }
Review comment:
Thanks for your comment.
The `INSTANCE` is defined to return a new `PosistionVectorReader`. It
doesn't have a class scope field such as `instance` and the null checking
logic, so it is not a singleton.
IIUC, spark will assign the number of `spark.executor.cores` of tasks per
executor.
##########
File path:
arrow/src/main/java/org/apache/iceberg/arrow/vectorized/VectorizedArrowReader.java
##########
@@ -332,6 +334,10 @@ public static VectorizedArrowReader nulls() {
return NullVectorReader.INSTANCE;
}
+ public static VectorizedArrowReader positions() {
+ return PositionVectorReader.INSTANCE;
+ }
Review comment:
Thanks for your comment.
The `INSTANCE` is defined to return a new `PosistionVectorReader`. It
doesn't have a class scope field such as `instance` and the null checking
logic, so it is not a singleton.
IIUC, spark will assign the number of `spark.executor.cores` of tasks per
executor.
##########
File path:
arrow/src/main/java/org/apache/iceberg/arrow/vectorized/VectorizedArrowReader.java
##########
@@ -332,6 +334,10 @@ public static VectorizedArrowReader nulls() {
return NullVectorReader.INSTANCE;
}
+ public static VectorizedArrowReader positions() {
+ return PositionVectorReader.INSTANCE;
+ }
Review comment:
Thanks for your comment.
The `INSTANCE` is defined to return a new `PosistionVectorReader`. It
doesn't have a class scope field such as `instance` and the null checking
logic, so it is not a singleton.
IIUC, spark will assign the number of `spark.executor.cores` of tasks per
executor.
##########
File path:
arrow/src/main/java/org/apache/iceberg/arrow/vectorized/VectorizedArrowReader.java
##########
@@ -332,6 +334,10 @@ public static VectorizedArrowReader nulls() {
return NullVectorReader.INSTANCE;
}
+ public static VectorizedArrowReader positions() {
+ return PositionVectorReader.INSTANCE;
+ }
Review comment:
Thanks for your comment.
The `INSTANCE` is defined to return a new `PosistionVectorReader`. It
doesn't have a class scope field such as `instance` and the null checking
logic, so it is not a singleton.
IIUC, spark will assign the number of `spark.executor.cores` of tasks per
executor.
##########
File path:
arrow/src/main/java/org/apache/iceberg/arrow/vectorized/VectorizedArrowReader.java
##########
@@ -332,6 +334,10 @@ public static VectorizedArrowReader nulls() {
return NullVectorReader.INSTANCE;
}
+ public static VectorizedArrowReader positions() {
+ return PositionVectorReader.INSTANCE;
+ }
Review comment:
Thanks for your comment.
The `INSTANCE` is defined to return a new `PosistionVectorReader`. It
doesn't have a class scope field such as `instance` and the null checking
logic, so it is not a singleton.
IIUC, spark will assign the number of `spark.executor.cores` of tasks per
executor.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
