shardulm94 commented on a change in pull request #1356:
URL: https://github.com/apache/iceberg/pull/1356#discussion_r487502065
##########
File path:
arrow/src/main/java/org/apache/iceberg/arrow/vectorized/VectorizedArrowReader.java
##########
@@ -332,6 +334,10 @@ public static VectorizedArrowReader nulls() {
return NullVectorReader.INSTANCE;
}
+ public static VectorizedArrowReader positions() {
+ return PositionVectorReader.INSTANCE;
+ }
Review comment:
The `INSTANCE` field is defined is static, so I am guessing `new
PositionVectorReader()` will only be called once when the class is being loaded
by the JVM. So this seems like mimicking a singleton to me, unless I am reading
the things wrongly.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
