HuaHuaY commented on code in PR #211:
URL: https://github.com/apache/iceberg-cpp/pull/211#discussion_r2327959228
##########
src/iceberg/transform.h:
##########
@@ -56,8 +57,40 @@ enum class TransformType {
kVoid,
};
+constexpr std::string_view kUnknownName = "unknown";
Review Comment:
> So these warnings are reported from CI, can you post a link?
Other warnings are reported from CI, this constexpr function is reported in
my environment. Without this fix, I can't compile in my MacOS.
```sh
[build] In file included from
/Users/huahua/github/iceberg-cpp/test/transform_test.cc:20:
[build] /Users/huahua/github/iceberg-cpp/src/iceberg/transform.h:60:43:
error: inline function 'iceberg::TransformTypeToString' is not defined
[-Werror,-Wundefined-inline]
[build] 60 | ICEBERG_EXPORT constexpr std::string_view
TransformTypeToString(TransformType type);
[build] | ^
[build] /Users/huahua/github/iceberg-cpp/test/transform_test.cc:91:39: note:
used here
[build] 91 | std::format("{}[{}]",
TransformTypeToString(c.type), *c.param));
[build] | ^
[build] 1 error generated.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
