raulcd commented on code in PR #211:
URL: https://github.com/apache/iceberg-cpp/pull/211#discussion_r2329486553
##########
cmake_modules/IcebergBuildUtils.cmake:
##########
@@ -131,7 +131,7 @@ function(add_iceberg_lib LIB_NAME)
endif()
if(LIB_INCLUDES)
- target_include_directories(${LIB_NAME}_shared SYSTEM PUBLIC
${ARG_EXTRA_INCLUDES})
Review Comment:
This was added ~7 years ago here:
https://github.com/apache/arrow/commit/5c97cd6bfd447dcc3d8d2b8e6debe6b92b8c1b42
I also think `SYSTEM` is not required, we could try removing it on ARROW too
and validate CI, Python bindings builds, etcetera.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
