HuaHuaY commented on code in PR #211:
URL: https://github.com/apache/iceberg-cpp/pull/211#discussion_r2329005300
##########
cmake_modules/IcebergBuildUtils.cmake:
##########
@@ -131,7 +131,7 @@ function(add_iceberg_lib LIB_NAME)
endif()
if(LIB_INCLUDES)
- target_include_directories(${LIB_NAME}_shared SYSTEM PUBLIC
${ARG_EXTRA_INCLUDES})
Review Comment:
I read arrow's cmake files. It doesn't use the parameter `EXTRA_INCLUDES` of
`add_arrow_lib`. So maybe we misunderstand the meaning of `EXTRA_INCLUDES` and
we should modify the caller of `add_iceberg_lib` instead of here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
