danielcweeks commented on code in PR #14178:
URL: https://github.com/apache/iceberg/pull/14178#discussion_r2399847635
##########
aws/src/main/java/org/apache/iceberg/aws/s3/signer/S3V4RestSignerClient.java:
##########
@@ -101,6 +102,11 @@ public String endpoint() {
return properties().getOrDefault(S3_SIGNER_ENDPOINT,
S3_SIGNER_DEFAULT_ENDPOINT);
}
+ @Value.Lazy
+ public String endpointUri() {
Review Comment:
Why aren't we just changing the `endpoint()` behavior? It looks like it's
now only being used by `endpointUri()`, so can't we just update how we return
the endpoint?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
