danielcweeks commented on code in PR #14178:
URL: https://github.com/apache/iceberg/pull/14178#discussion_r2402474578
##########
aws/src/main/java/org/apache/iceberg/aws/s3/signer/S3V4RestSignerClient.java:
##########
@@ -101,6 +102,11 @@ public String endpoint() {
return properties().getOrDefault(S3_SIGNER_ENDPOINT,
S3_SIGNER_DEFAULT_ENDPOINT);
}
+ @Value.Lazy
+ public String endpointUri() {
Review Comment:
Is this actually changing the behavior though? We're just returning the
endpoint constructed at request time rather than at creation time? I think the
expectation is that whatever comes from the `endpoint()` call should reflect
the url to be called.
If we think it's a significant behavior change, then we should deprecate the
other so that we don't have two different paths for getting the endpoint
(that's awkward to carry forward)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
