ahmarsuhail commented on code in PR #14329:
URL: https://github.com/apache/iceberg/pull/14329#discussion_r2429918193
##########
aws/src/main/java/org/apache/iceberg/aws/s3/S3InputFile.java:
##########
@@ -76,7 +76,7 @@ public SeekableInputStream newStream() {
if (s3FileIOProperties().isS3AnalyticsAcceleratorEnabled()) {
return AnalyticsAcceleratorUtil.newStream(this);
}
- return new S3InputStream(client(), uri(), s3FileIOProperties(), metrics());
+ return new S3InputStream(client(), uri(), s3FileIOProperties(), metrics(),
getLength());
Review Comment:
So you're saying removing the `LOG.warn("An error occurred while aborting
the stream", e);`? Not sure if we want that `abort()` to fail silently.
I'm trying to see if I can figure out what it really means if an `abort()`
fails on a stream that threw an exception. For eg, what's happening right now
is:
```
* We opened a stream from 0-EoF, where EoF is 500MB
* After reading 100MB, a retryable exception was thrown
* In the resetForRetry(), abort() is called, but it fails because the
`read()` fails.
```
My expectation is that since the underlying stream already failed, it's
released that connection and the `abort()`/`close()` is a NOOP at this point.
but i'm concerned that the `abort()` failing might mean that connections aren't
getting released properly. Will try to confirm.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
