danielcweeks commented on code in PR #14329:
URL: https://github.com/apache/iceberg/pull/14329#discussion_r2430044946
##########
aws/src/main/java/org/apache/iceberg/aws/s3/S3InputStream.java:
##########
@@ -86,15 +92,20 @@ class S3InputStream extends SeekableInputStream implements
RangeReadable {
.withMaxRetries(3)
.build();
- S3InputStream(S3Client s3, S3URI location) {
- this(s3, location, new S3FileIOProperties(), MetricsContext.nullMetrics());
+ S3InputStream(S3Client s3, S3URI location, long contentLength) {
Review Comment:
This class is protected/private so we don't necessarily need to create a new
constructor, but I'm not convinced we actually should do this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
