singhpk234 commented on code in PR #14329:
URL: https://github.com/apache/iceberg/pull/14329#discussion_r2429849203
##########
aws/src/main/java/org/apache/iceberg/aws/s3/S3InputFile.java:
##########
@@ -76,7 +76,7 @@ public SeekableInputStream newStream() {
if (s3FileIOProperties().isS3AnalyticsAcceleratorEnabled()) {
return AnalyticsAcceleratorUtil.newStream(this);
}
- return new S3InputStream(client(), uri(), s3FileIOProperties(), metrics());
+ return new S3InputStream(client(), uri(), s3FileIOProperties(), metrics(),
getLength());
Review Comment:
> by this point we should already have the length and this shouldn't result
in a new HEAD call
Icebergs metadata.json and manifest list would not have content length but
subsequent reads down the iceberg metadata tree i,e mainifest / data / delete
files should have it
How about correcting the error message ? if this is too much of a noise
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
