amogh-jahagirdar commented on code in PR #14197:
URL: https://github.com/apache/iceberg/pull/14197#discussion_r2392028379
##########
core/src/main/java/org/apache/iceberg/io/BaseTaskWriter.java:
##########
@@ -115,20 +115,32 @@ public WriteResult complete() throws IOException {
protected abstract class BaseEqualityDeltaWriter implements Closeable {
private final StructProjection structProjection;
private final PositionDelete<T> positionDelete;
+ private final StructLike partitionKey;
+ private final boolean useDv;
Review Comment:
In the spark position delta write logic, we abstract both pos delete/and the
dv writer behind the `PartitioningWriter` interface. Is that not possible here?
THen we just pass in a PartitioningWriter interface (or a supplier of a
partitioning writer interface)....
https://github.com/apache/iceberg/blob/main/spark/v4.0/spark/src/main/java/org/apache/iceberg/spark/source/SparkPositionDeltaWrite.java#L519
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
