Guosmilesmile commented on code in PR #14197:
URL: https://github.com/apache/iceberg/pull/14197#discussion_r2386838508
##########
flink/v2.1/flink/src/main/java/org/apache/iceberg/flink/sink/dynamic/DynamicWriteResultAggregator.java:
##########
@@ -167,7 +167,8 @@ byte[] writeToManifest(
FlinkManifestUtil.writeCompletedFiles(
result,
() -> outputFileFactory(key.tableName()).create(checkpointId),
- spec(key.tableName(), key.specId()));
+ spec(key.tableName(), key.specId()),
+ 2);
Review Comment:
> the DV needs the commit summary which contains the partition values for
the DV？
The changes here are completed by this
PR(https://github.com/apache/iceberg/pull/11446). I understand that
`contentSizeInBytes` is used instead of `fileSizeInBytes` here because puffin
files have a metadata section.
> Can we just start storing the info for every Delete file?
I think this is essentially due to the metadata change after switching from
V2 tables to V3 tables. `CommitSummary` is mainly used for statistical
information to provide data for post-commit operations. Using `fileSizeInBytes`
in the dynamic sink should have no impact, but since `CommitSummary` is shared
by all sinks, branch logic would be needed. I'm not sure if this is appropriate.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
