Guosmilesmile commented on code in PR #14197:
URL: https://github.com/apache/iceberg/pull/14197#discussion_r2390422806
##########
core/src/main/java/org/apache/iceberg/io/PartitioningDVWriter.java:
##########
@@ -60,6 +61,11 @@ public void close() throws IOException {
if (result == null) {
writer.close();
this.result = writer.result();
+ this.closed = true;
}
}
+
+ public boolean closed() {
Review Comment:
In the partition writer, sharing a dvs write means that when the partition
writers call close to obtain the writeresult, they will repeatedly get the same
result. Therefore, a flag is needed to ensure that the result set is obtained
only once.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
