Guosmilesmile commented on code in PR #14197:
URL: https://github.com/apache/iceberg/pull/14197#discussion_r2442478443
##########
flink/v2.1/flink/src/main/java/org/apache/iceberg/flink/sink/PartitionedDeltaWriter.java:
##########
@@ -74,7 +81,11 @@ RowDataDeltaWriter route(RowData row) {
// NOTICE: we need to copy a new partition key here, in case of messing
up the keys in
// writers.
PartitionKey copiedKey = partitionKey.copy();
- writer = new RowDataDeltaWriter(copiedKey);
+ if (dvFileWriter == null && useDv) {
+ this.dvFileWriter = new PartitioningDVWriter<>(fileFactory, p -> null);
+ }
Review Comment:
You are right, I should move create to constructor, then we don't need to
store the flag.
Do it .
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
