pvary commented on code in PR #14210:
URL: https://github.com/apache/iceberg/pull/14210#discussion_r2428382797
##########
data/src/test/java/org/apache/iceberg/data/TestGenericFileWriterFactory.java:
##########
@@ -57,4 +59,9 @@ protected StructLikeSet toSet(Iterable<Record> records) {
records.forEach(set::add);
return set;
}
+
+ @Disabled("Position deletes with row data are no longer supported")
+ @Override
+ @TestTemplate
+ public void testPositionDeleteWriterWithRow() throws IOException {}
Review Comment:
Basically it disables the test method which is implemented in the parent
test class.
Alternatively we can remove the method from the parent test class, and move
it to the classes which still need to keep the feature.
I opted for this solution because the changeset is smaller in this way
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
