pvary commented on code in PR #14210:
URL: https://github.com/apache/iceberg/pull/14210#discussion_r2390965744
##########
spark/v3.4/spark/src/main/java/org/apache/iceberg/spark/source/SparkFileWriterFactory.java:
##########
@@ -50,6 +50,13 @@ class SparkFileWriterFactory extends
BaseFileWriterFactory<InternalRow> {
private StructType positionDeleteSparkType;
private final Map<String, String> writeProperties;
+ /**
+ * @deprecated This constructor is deprecated as of version 1.11.0 and will
be removed in 1.12.0.
+ * Position deletes that include row data are no longer supported. Use
{@link
+ * #SparkFileWriterFactory(Table, FileFormat, Schema, StructType,
SortOrder, FileFormat,
+ * int[], Schema, StructType, SortOrder, Map)} instead.
+ */
+ @Deprecated
Review Comment:
We need to keep this, because `SparkPositionDeltaWrite` supports rewriting
position deletes with row content.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
