pvary commented on code in PR #14210:
URL: https://github.com/apache/iceberg/pull/14210#discussion_r2428370687
##########
flink/v1.20/flink/src/test/java/org/apache/iceberg/flink/sink/TestFlinkWriterMetrics.java:
##########
@@ -57,4 +59,14 @@ public RowData toGenericRow(int value, int repeated) {
}
return row;
}
+
+ @Override
+ protected void checkRowStatistics(Map<Integer, ByteBuffer> bounds) {
+ assertThat(bounds).hasSize(2);
+ }
+
+ @Override
+ protected void checkNotExistingRowStatistics(Map<Integer, ByteBuffer>
bounds) {
+ assertThat(bounds).isNull();
+ }
Review Comment:
SparkFileWriterFactory currently uses the PositionDeletes with row data when
the `SparkPositionDeltaWrite` rewrites position deletes with row content. We
deprecate this feature in 1.11.0, but we can only remove it in 1.12.0. Until
this point we keep the feature and the tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
