aokolnychyi commented on pull request #1665: URL: https://github.com/apache/iceberg/pull/1665#issuecomment-716780997
This PR touches a lot of places (i.e. each query engine integration) since it relies on the mechanism to propagate table props to the Parquet reader builder. We have something similar for our write options. We have to be careful with serialization since table properties can be Guava `ImmutableList` that will cause troubles for custom serialization mechanisms that query engines may use (e.g. Kryo). If I remember correctly, Spark still uses Java serialization for its tasks but I am not sure about other query engines. That being said, we already propagate write properties so the issue (if any) is already there. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
