RussellSpitzer commented on a change in pull request #1665:
URL: https://github.com/apache/iceberg/pull/1665#discussion_r512254330
##########
File path:
spark/src/main/java/org/apache/iceberg/spark/source/RowDataReader.java
##########
@@ -140,6 +142,9 @@
builder.withNameMapping(NameMappingParser.fromJson(nameMapping));
}
+ // TODO: propagate properties for Avro
+ // properties.forEach(builder::set);
Review comment:
Maybe we should have an Precondition til this is implemented throwing an
exception if a property is passed
##########
File path:
spark/src/main/java/org/apache/iceberg/spark/source/RowDataReader.java
##########
@@ -140,6 +142,9 @@
builder.withNameMapping(NameMappingParser.fromJson(nameMapping));
}
+ // TODO: propagate properties for Avro
+ // properties.forEach(builder::set);
Review comment:
Maybe we should have an Precondition until this is implemented throwing
an exception if a property is passed
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
