rdblue commented on pull request #1665: URL: https://github.com/apache/iceberg/pull/1665#issuecomment-717433532
Overall, I think this looks good. It would be nice to separate the actual fix into a separate PR, though. Right now, there are a lot of changes that just add properties to different methods and objects. It would be great to have a PR focused on just the changes to Parquet filters that uses a hard-coded limit (200). That would make it easier to check those changes and would be easier for maintainers to cherry-pick this to internal branches. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
