aokolnychyi commented on a change in pull request #1665:
URL: https://github.com/apache/iceberg/pull/1665#discussion_r512969928
##########
File path:
spark/src/main/java/org/apache/iceberg/spark/source/RowDataReader.java
##########
@@ -140,6 +142,9 @@
builder.withNameMapping(NameMappingParser.fromJson(nameMapping));
}
+ // TODO: propagate properties for Avro
+ // properties.forEach(builder::set);
Review comment:
As it stands today, all table props are passed here so this precondition
will always fail. We may want to consider setting only those table props that
start with `read.parquet` for Parquet or `read.avro` for Avro. Then a
precondition here would work as we ensure props only contain relevant configs.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
