singhpk234 commented on code in PR #14329:
URL: https://github.com/apache/iceberg/pull/14329#discussion_r2429949876
##########
aws/src/main/java/org/apache/iceberg/aws/s3/S3InputFile.java:
##########
@@ -76,7 +76,7 @@ public SeekableInputStream newStream() {
if (s3FileIOProperties().isS3AnalyticsAcceleratorEnabled()) {
return AnalyticsAcceleratorUtil.newStream(this);
}
- return new S3InputStream(client(), uri(), s3FileIOProperties(), metrics());
+ return new S3InputStream(client(), uri(), s3FileIOProperties(), metrics(),
getLength());
Review Comment:
I am not saying removing, i am saying better rephrasing ?
> that the abort() failing might mean that connections aren't getting
released properly.Will try to confirm.
agree, it will be a good thing to confirm if failure when aborting the
stream leads to connection not being released in the pool, then i think its a
valid tradeoff vs introducing a new getLenght() for some objects
abort() was introduced here as an optimization in the first place to reuse
connection, please ref:
https://github.com/apache/iceberg/pull/7262/files#r1156363240
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
