smaheshwar-pltr commented on code in PR #13225:
URL: https://github.com/apache/iceberg/pull/13225#discussion_r2471505710
##########
core/src/main/java/org/apache/iceberg/rest/RESTTableOperations.java:
##########
@@ -57,27 +65,45 @@ enum UpdateType {
private final String path;
private final Supplier<Map<String, String>> headers;
private final FileIO io;
+ private final KeyManagementClient kmsClient;
private final List<MetadataUpdate> createChanges;
private final TableMetadata replaceBase;
private final Set<Endpoint> endpoints;
private UpdateType updateType;
private TableMetadata current;
+ private EncryptionManager encryptionManager;
+ private EncryptingFileIO encryptingFileIO;
+ private String tableKeyId;
+ private int encryptionDekLength;
+ private List<EncryptedKey> encryptedKeysFromMetadata;
Review Comment:
Thanks, I'll need to think about whether those changes are needed here
actually, given the metadata file equality check in `updateCurrentMetadata`
(test passes).
I suspect it's best to have such changes so when there's new metadata, the
old keys are kept around. Will have to think if there's a case for this though
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
