majian1998 commented on code in PR #14497:
URL: https://github.com/apache/iceberg/pull/14497#discussion_r2488799846
##########
spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/ExtendedParser.java:
##########
@@ -74,18 +76,15 @@ private static <T> T findParser(ParserInterface parser,
Class<T> clazz) {
return clazz.cast(current);
}
- ParserInterface next = getNextDelegateParser(current);
- if (next == null) {
- break;
- }
-
- current = next;
+ current = getNextDelegateParser(current);
}
return null;
}
private static ParserInterface getNextDelegateParser(ParserInterface parser)
{
+ Logger logger = LoggerFactory.getLogger(ExtendedParser.class);
Review Comment:
Interface fields cannot be private in Java.
Can the code be written like this?
```
public interface ExtendedParser extends ParserInterface {
Logger LOG = LoggerFactory.getLogger(ExtendedParser.class);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
