ebyhr commented on code in PR #14497:
URL: https://github.com/apache/iceberg/pull/14497#discussion_r2489237135
##########
spark/v4.0/spark/src/main/java/org/apache/iceberg/spark/ExtendedParser.java:
##########
@@ -100,6 +99,7 @@ private static ParserInterface
getNextDelegateParser(ParserInterface parser) {
}
} catch (Exception e) {
// ignore
Review Comment:
I think we can remove this comment now. This comment was there to suppress
"Empty 'catch' block" warning.
##########
spark/v4.0/spark/src/main/java/org/apache/iceberg/spark/ExtendedParser.java:
##########
@@ -100,6 +99,7 @@ private static ParserInterface
getNextDelegateParser(ParserInterface parser) {
}
} catch (Exception e) {
// ignore
+ LOG.warn("Failed to scan delegate parser in {}: {}",
parser.getClass().getName(), e);
Review Comment:
We don't need to append `: {}` for `e`, right?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
