huaxingao commented on code in PR #14497:
URL: https://github.com/apache/iceberg/pull/14497#discussion_r2492754343
##########
spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/ExtendedParser.java:
##########
@@ -26,8 +26,12 @@
import org.apache.spark.sql.AnalysisException;
import org.apache.spark.sql.SparkSession;
import org.apache.spark.sql.catalyst.parser.ParserInterface;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
public interface ExtendedParser extends ParserInterface {
+ Logger LOG = LoggerFactory.getLogger(ExtendedParser.class);
Review Comment:
This is implicitly public. Maybe use
```
private static Logger log() {
return LoggerFactory.getLogger(ExtendedParser.class);
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
