majian1998 commented on code in PR #14497:
URL: https://github.com/apache/iceberg/pull/14497#discussion_r2488812347
##########
spark/v3.5/spark-extensions/src/test/java/org/apache/iceberg/spark/TestExtendedParser.java:
##########
@@ -67,6 +70,10 @@ public void saveOriginalParser() throws Exception {
try {
parserField = clazz.getDeclaredField(SQL_PARSER_FIELD);
} catch (NoSuchFieldException e) {
+ LOG.warn(
+ "Field '{}' not found in class {}. Trying superclass.",
+ SQL_PARSER_FIELD,
+ clazz.getName());
Review Comment:
> @kamcheungting-db: add log to help RCA if something goes wrong
Added logs based on suggestion, just in case.
If you feel they're unnecessary in the test class, we can remove them.
##########
spark/v3.5/spark-extensions/src/test/java/org/apache/iceberg/spark/TestExtendedParser.java:
##########
@@ -67,6 +70,10 @@ public void saveOriginalParser() throws Exception {
try {
parserField = clazz.getDeclaredField(SQL_PARSER_FIELD);
} catch (NoSuchFieldException e) {
+ LOG.warn(
+ "Field '{}' not found in class {}. Trying superclass.",
+ SQL_PARSER_FIELD,
+ clazz.getName());
Review Comment:
> @kamcheungting-db: add log to help RCA if something goes wrong
Added logs based on suggestion, just in case.
If you feel they're unnecessary in the test class, we can remove them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
