mxm commented on code in PR #14581:
URL: https://github.com/apache/iceberg/pull/14581#discussion_r2526751461
##########
core/src/main/java/org/apache/iceberg/BaseRowDelta.java:
##########
@@ -48,6 +48,10 @@ protected BaseRowDelta self() {
@Override
protected String operation() {
+ if (addsDataFiles() && !addsDeleteFiles() && !deletesDataFiles()) {
Review Comment:
Thanks for the review @singhpk234 and @pvary! Should we change the DELETE
path to something like:
```java
if (addsDeleteFiles() && !addsDataFiles() && !deletesDeleteFiles()) {
return DataOperations.DELETE;
}
```
Or do you prefer to do this in a separate PR? Originally, this PR is meant
to optimize the APPEND case only.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
