mxm commented on code in PR #14581:
URL: https://github.com/apache/iceberg/pull/14581#discussion_r2528275011
##########
core/src/main/java/org/apache/iceberg/BaseRowDelta.java:
##########
@@ -48,6 +48,10 @@ protected BaseRowDelta self() {
@Override
protected String operation() {
+ if (addsDataFiles() && !addsDeleteFiles() && !deletesDataFiles()) {
Review Comment:
Indeed, it seems rare that we would delete a delete file to resurrect
deleted data, but you are right about V3+ DV delete files triggering the above
condition due to removing the old delete file and adding the rewritten one,
e.g.:
https://github.com/apache/iceberg/blob/571b696106f4748d3edee9ee641e214377ddcb16/spark/v4.0/spark/src/main/java/org/apache/iceberg/spark/source/SparkPositionDeltaWrite.java#L232
Maybe we just leave things as-is for DELETE? My intention anyways was to fix
the APPEND case :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
