stevenzwu commented on code in PR #14581:
URL: https://github.com/apache/iceberg/pull/14581#discussion_r2535512806
##########
core/src/main/java/org/apache/iceberg/BaseRowDelta.java:
##########
@@ -48,6 +48,10 @@ protected BaseRowDelta self() {
@Override
protected String operation() {
+ if (addsDataFiles() && !addsDeleteFiles() && !deletesDataFiles()) {
Review Comment:
> The more I think of v3 case i can think of we undelete a row from a file
so for a file i can have a DV replaced by another DV with less number of bits
set, since deletes are no longer stiched to data files via seq number
Should this be allowed? It can mess up the row lineage. Essentially, a row
is added (back) to the table with lower/old row_id with such DV operation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
