singhpk234 commented on code in PR #14581:
URL: https://github.com/apache/iceberg/pull/14581#discussion_r2533057189
##########
core/src/main/java/org/apache/iceberg/BaseRowDelta.java:
##########
@@ -48,6 +48,10 @@ protected BaseRowDelta self() {
@Override
protected String operation() {
+ if (addsDataFiles() && !addsDeleteFiles() && !deletesDataFiles()) {
Review Comment:
Seems like we need to fix this for V3 DVs(thanks for raising this @pvary and
confirming this @mxm)
The more I think of v3 case i can think of we undelete a row from a file so
for a file i can have a DV replaced by another DV with less number of bits set,
since deletes are no longer stiched to data files via seq number
For now may be we should gaurd this with V2 check (seperate PR is fine or in
case you are bust just filing a ticket would be really helpful )
```
if (addsDeleteFiles() && !addsDataFiles()) {
if (ops.current().formatVersion() == V2)
return DataOperations.DELETE;
}
```
For now we can keep this pr focused for APPEND case WDYT @pvary ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
