liukun4515 commented on a change in pull request #1715:
URL: https://github.com/apache/iceberg/pull/1715#discussion_r517071534
##########
File path: spark/src/main/java/org/apache/iceberg/actions/BaseAction.java
##########
@@ -144,6 +123,32 @@ protected String metadataTableName(String tableName,
MetadataTableType type) {
return manifestDF.union(otherMetadataFileDF).union(manifestListDF);
}
+ protected Dataset<Row> loadMetadataTable(SparkSession spark, String
tableName, MetadataTableType type) {
+ String metadataTableName = metadataTableName(tableName, type);
Review comment:
Maybe this method can not handle some corner cases.
For example, in the spark2 action, the file_path is very special
(file://level1.level2.level3.level4/database/table).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
