RussellSpitzer commented on a change in pull request #1715:
URL: https://github.com/apache/iceberg/pull/1715#discussion_r517088133
##########
File path: spark/src/main/java/org/apache/iceberg/actions/BaseSparkAction.java
##########
@@ -86,6 +125,33 @@
return manifestDF.union(otherMetadataFileDF).union(manifestListDF);
}
+ protected static Dataset<Row> loadMetadataTable(SparkSession spark, String
tableName, String tableLocation,
Review comment:
I didn't want to make these static, but because two of the actions no
longer extend BaseSparkActions they cannot access these methods anymore. I
think in the future we should try our best to keep from having Actions
implementing "BaseAction" if we can help it so that the implementations of
frame work specific code can use their shared methods.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
