RussellSpitzer commented on pull request #1715: URL: https://github.com/apache/iceberg/pull/1715#issuecomment-721740878
> > @zhangjun0x01 You may want to take a look at this, especially if you have an Idea on how to make the Spark Actions all extend BaseSparkAction > > I extracted getManifestListPathsăgetOtherMetadataFilePaths and other methods from spark to BaseAction. I think if we do RemoveOrphanFilesAction and ExpireSnapshotsAction for flink in the future, we can use these methods. > > My idea is to put the common part of spark actions into BaseSparkAction, and put the common part of spark and flink into BaseAction The problem with this is that we now have some actions which must extend BaseAction and not BaseSparkAction, like https://github.com/apache/iceberg/blob/f9f5bcfe66be2c808a4f14f59c195f92c31de8fa/core/src/main/java/org/apache/iceberg/actions/BaseSnapshotUpdateAction.java#L26 If we follow this pattern, all actions derived from this base cannot use FlinkActions or SparkActions, they can only use BaseAction ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
