zhangjun0x01 commented on pull request #1715:
URL: https://github.com/apache/iceberg/pull/1715#issuecomment-722735628


   > I think we could rename it in another PR? but I'm still not sure the 
current split makes sense since if we end up with more actions that share code 
through a base class that inherits from BaseAction, we can discuss that later.
   
   Maybe we have not done more flink actions, so it may not make much sense at 
the moment, we can consider extract common logic when we use it in the future


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to