zhjwpku commented on PR #317: URL: https://github.com/apache/iceberg-cpp/pull/317#issuecomment-3539665515
Some unclear points while porting Java's TestManifestWriterVersions: - Should we update the ManifestFile's sequence number when writing to ManifestList? - Should we update ManifestEntry's status to Delete when performing AddDeleteEntry? I've temporarily commented out some failing assertions, but the PR seems ready for review, just pay special attention to the above two questions. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
