zhjwpku commented on code in PR #317:
URL: https://github.com/apache/iceberg-cpp/pull/317#discussion_r2549989752


##########
src/iceberg/manifest_writer.h:
##########
@@ -54,9 +69,15 @@ class ICEBERG_EXPORT ManifestWriter {
   /// \brief Close writer and flush to storage.
   Status Close();
 
+  /// \brief Get the metrics of written manifest file.
+  std::optional<Metrics> metrics() const;
+
   /// \brief Get the content of the manifest.
   ManifestContent content() const;
 
+  /// \brief Get the ManifestFile object.
+  Result<ManifestFile> ToManifestFile() const;

Review Comment:
   Done.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to