zhjwpku commented on code in PR #317:
URL: https://github.com/apache/iceberg-cpp/pull/317#discussion_r2549991025
##########
src/iceberg/manifest_writer.h:
##########
@@ -103,6 +124,10 @@ class ICEBERG_EXPORT ManifestWriter {
static constexpr int64_t kBatchSize = 1024;
std::unique_ptr<Writer> writer_;
std::unique_ptr<ManifestEntryAdapter> adapter_;
+ bool closed_{false};
+ std::string manifest_location_;
+ // TODO(zhjwpku): consider passing key metadata when makeing ManifestWriter.
+ std::vector<uint8_t> key_metadata_;
Review Comment:
removed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
