zhjwpku commented on code in PR #317:
URL: https://github.com/apache/iceberg-cpp/pull/317#discussion_r2550005412
##########
src/iceberg/manifest_writer.h:
##########
@@ -36,15 +38,28 @@ namespace iceberg {
class ICEBERG_EXPORT ManifestWriter {
public:
ManifestWriter(std::unique_ptr<Writer> writer,
- std::unique_ptr<ManifestEntryAdapter> adapter)
- : writer_(std::move(writer)), adapter_(std::move(adapter)) {}
+ std::unique_ptr<ManifestEntryAdapter> adapter,
+ std::string_view manifest_location)
+ : writer_(std::move(writer)),
+ adapter_(std::move(adapter)),
+ manifest_location_(manifest_location) {}
~ManifestWriter() = default;
- /// \brief Write manifest entry to file.
+ /// \brief Add a new Manifest entry.
/// \param entry Manifest entry to write.
/// \return Status::OK() if entry was written successfully
- Status Add(const ManifestEntry& entry);
+ Status AddEntry(const ManifestEntry& entry);
Review Comment:
Good idea, I tried this, please take a look again.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
