aokolnychyi commented on a change in pull request #1738:
URL: https://github.com/apache/iceberg/pull/1738#discussion_r519551328



##########
File path: core/src/main/java/org/apache/iceberg/TableProperties.java
##########
@@ -134,4 +134,10 @@ private TableProperties() {
 
   public static final String ENGINE_HIVE_ENABLED = "engine.hive.enabled";
   public static final boolean ENGINE_HIVE_ENABLED_DEFAULT = false;
+
+  public static final String ROW_LEVEL_OPS_ISOLATION_LEVEL = 
"row-level-ops.isolation-level";
+  public static final String ROW_LEVEL_OPS_ISOLATION_LEVEL_DEFAULT = 
"serializable";

Review comment:
       Do we want to make this property specific to Spark? Seems generic enough 
and I hope it will be respected by other query engines in the future too.
   
   If we want to keep it Spark specific, it is going to be the first Spark 
table property. The only other query engine specific property is 
`engine.hive.enabled`. Do we want to share the `engine` prefix in this case?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to