aokolnychyi commented on a change in pull request #1738:
URL: https://github.com/apache/iceberg/pull/1738#discussion_r519551905
##########
File path: core/src/main/java/org/apache/iceberg/TableProperties.java
##########
@@ -134,4 +134,10 @@ private TableProperties() {
public static final String ENGINE_HIVE_ENABLED = "engine.hive.enabled";
public static final boolean ENGINE_HIVE_ENABLED_DEFAULT = false;
+
+ public static final String ROW_LEVEL_OPS_ISOLATION_LEVEL =
"row-level-ops.isolation-level";
+ public static final String ROW_LEVEL_OPS_ISOLATION_LEVEL_DEFAULT =
"serializable";
+
+ public static final String ROW_LEVEL_OPS_MODE = "row-level-ops.mode";
+ public static final String ROW_LEVEL_OPS_MODE_DEFAULT = "copy-on-write";
Review comment:
I'll be happy to reconsider the naming but `write.spark.mode` seems to
generic to me. If I read it in the docs, it would not be immediately clear to
me that it applies only to UPDATE/DELETE/MERGE.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
