rdblue commented on a change in pull request #1738:
URL: https://github.com/apache/iceberg/pull/1738#discussion_r519991445
##########
File path: core/src/main/java/org/apache/iceberg/TableProperties.java
##########
@@ -134,4 +134,10 @@ private TableProperties() {
public static final String ENGINE_HIVE_ENABLED = "engine.hive.enabled";
public static final boolean ENGINE_HIVE_ENABLED_DEFAULT = false;
+
+ public static final String ROW_LEVEL_OPS_ISOLATION_LEVEL =
"row-level-ops.isolation-level";
+ public static final String ROW_LEVEL_OPS_ISOLATION_LEVEL_DEFAULT =
"serializable";
Review comment:
I'd probably group this in `write` because it is a setting that affects
write behavior. If we don't want it to be specific to Spark, then we can make
it `write.isolation.default-level` maybe?
I'm okay not making it specific to Spark, but it may be something that not
every engine respects. Are we okay with that?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
