rdblue commented on a change in pull request #1738:
URL: https://github.com/apache/iceberg/pull/1738#discussion_r519993678
##########
File path: core/src/main/java/org/apache/iceberg/TableProperties.java
##########
@@ -134,4 +134,10 @@ private TableProperties() {
public static final String ENGINE_HIVE_ENABLED = "engine.hive.enabled";
public static final boolean ENGINE_HIVE_ENABLED_DEFAULT = false;
+
+ public static final String ROW_LEVEL_OPS_ISOLATION_LEVEL =
"row-level-ops.isolation-level";
+ public static final String ROW_LEVEL_OPS_ISOLATION_LEVEL_DEFAULT =
"serializable";
+
+ public static final String ROW_LEVEL_OPS_MODE = "row-level-ops.mode";
+ public static final String ROW_LEVEL_OPS_MODE_DEFAULT = "copy-on-write";
Review comment:
I like to use `write` because it will control behavior at write time. If
we want this to be a general setting to prefer copy-on-write, then we could use
`write.row-level.mode`. I think that's specific. What do you think?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
