rdblue commented on a change in pull request #1747:
URL: https://github.com/apache/iceberg/pull/1747#discussion_r521654417
##########
File path:
api/src/main/java/org/apache/iceberg/expressions/BoundUnaryPredicate.java
##########
@@ -46,18 +46,35 @@ public boolean test(T value) {
return value == null;
case NOT_NULL:
return value != null;
+ case IS_NAN:
+ return isNaN(value);
+ case NOT_NAN:
+ return !isNaN(value);
default:
throw new IllegalStateException("Invalid operation for
BoundUnaryPredicate: " + op());
}
}
+ private boolean isNaN(T value) {
Review comment:
Should this be a static helper somewhere since it is duplicated here and
in `Evaluator`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
