rdblue commented on a change in pull request #1747:
URL: https://github.com/apache/iceberg/pull/1747#discussion_r521661724
##########
File path:
api/src/main/java/org/apache/iceberg/expressions/ManifestEvaluator.java
##########
@@ -142,6 +142,25 @@ public Boolean or(Boolean leftResult, Boolean rightResult)
{
return ROWS_MIGHT_MATCH;
}
+ @Override
+ public <T> Boolean isNaN(BoundReference<T> ref) {
+ int pos = Accessors.toPosition(ref.accessor());
+ // containsNull encodes whether at least one partition value is null,
lowerBound is null if
+ // all partition values are null.
+ ByteBuffer lowerBound = stats.get(pos).lowerBound();
+ if (lowerBound == null) {
Review comment:
To be safe, I think this should validate that `containsNull` is true.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
