rdblue commented on a change in pull request #1747:
URL: https://github.com/apache/iceberg/pull/1747#discussion_r521664276
##########
File path:
api/src/main/java/org/apache/iceberg/expressions/ResidualEvaluator.java
##########
@@ -152,6 +152,30 @@ public Expression or(Expression leftResult, Expression
rightResult) {
return (ref.eval(struct) != null) ? alwaysTrue() : alwaysFalse();
}
+ @Override
+ public <T> Expression isNaN(BoundReference<T> ref) {
+ return isNaN(ref.eval(struct)) ? alwaysTrue() : alwaysFalse();
+ }
+
+ @Override
+ public <T> Expression notNaN(BoundReference<T> ref) {
+ return isNaN(ref.eval(struct)) ? alwaysFalse() : alwaysTrue();
+ }
+
+ private <T> boolean isNaN(T value) {
Review comment:
Here's another implementation of the same test.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
