rdblue commented on a change in pull request #1747:
URL: https://github.com/apache/iceberg/pull/1747#discussion_r521662995
##########
File path:
api/src/main/java/org/apache/iceberg/expressions/StrictMetricsEvaluator.java
##########
@@ -57,10 +57,10 @@ public StrictMetricsEvaluator(Schema schema, Expression
unbound) {
}
/**
- * Test whether the file may contain records that match the expression.
+ * Test whether all records within the file match the expression.
*
* @param file a data file
- * @return false if the file cannot contain rows that match the expression,
true otherwise.
+ * @return false if the file may contain any row that doesn't match the
expression, true otherwise.
Review comment:
Good catch.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
